Go to file
Xavier Roirand cb923fcc23 Ada: fix bad handling in ada_convert_actual
Using this small example:

procedure Foo is

   type Integer_Access is access all Integer;

   procedure P (A : Integer_Access) is
   begin
      null;
   end P;

begin
   P (null);
end Foo;

and doing this debug session:

(gdb) b p
Breakpoint 1 at 0x402d67: file foo.adb, line 7.
(gdb) print p(null)

Breakpoint 1, foo.p (a=0x641010) at foo.adb:10
...                  ^^^^^^^^^^

shows that something goes wrong between the initial null value and the
received parameter value in the 'f' function.
The value for the parameter 'a' we get is the address of the value we
would expect instead of the value itself. This can be checked by doing:

(gdb) p *a
$1 = 0

Before this fix, in ada_convert_value, this function was looking to the
actual value (the null value here) to determine if the formal (parameter
'a' in the procedure 'P' in this exemple) requires a pointer or not which
is a wrong assumption and leads to push the address of the value to the
inferior instead of the value itself.

This is fixed by this patch.

gdb/ChangeLog:

        * ada-lang.c (ada_convert_actual): Change the way actual value
        are passed to the inferior when the inferior expects a pointer type.

gdb/testsuite/ChangeLog:

        * gdb.ada/funcall_ptr: New testcase.

Tested on x86_64-linux.
2017-12-17 22:01:32 -05:00
bfd Automatic date update in version.in 2017-12-18 00:00:20 +00:00
binutils binutils nm testsuite tidy 2017-12-14 22:29:42 +10:30
config
cpu
elfcpp oops - changelog entry omitted from previous delta 2017-09-21 09:07:11 +01:00
etc Update the address of the FSF in the copyright notice of files which were using the old address. 2017-12-14 12:48:55 +00:00
gas x86: Check pseudo prefix without instruction 2017-12-17 09:49:11 -08:00
gdb Ada: fix bad handling in ada_convert_actual 2017-12-17 22:01:32 -05:00
gold [GOLD] PR22602, handle __tls_get_addr forwarders properly 2017-12-15 15:09:15 +10:30
gprof Support --localedir, --datarootdir and --datadir 2017-11-29 20:10:52 +10:30
include Add plugin API for processing plugin-added input files 2017-12-11 14:58:38 -08:00
intl Require ngettext in test of system gettext implementation 2017-11-07 15:56:44 +10:30
ld Update the address of the FSF in the copyright notice of files which were using the old address. 2017-12-14 12:48:55 +00:00
libdecnumber
libiberty Sync libiberty/ & include/ with GCC 2017-09-15 17:40:33 +01:00
opcodes Fix disassembly for PowerPC 2017-12-15 19:52:49 +10:30
readline
sim sim: testsuite: add testsuite for or1k sim 2017-12-12 23:49:57 +09:00
texinfo
zlib
.cvsignore
.gitattributes
.gitignore
ChangeLog Update the address of the FSF in the copyright notice of files which were using the old address. 2017-12-14 12:48:55 +00:00
compile
config-ml.in
config.guess
config.rpath
config.sub
configure Add gdb for or1k build 2017-12-12 23:39:28 +09:00
configure.ac Add gdb for or1k build 2017-12-12 23:39:28 +09:00
COPYING
COPYING3
COPYING3.LIB
COPYING.LIB
COPYING.LIBGLOSS Update the address of the FSF in the copyright notice of files which were using the old address. 2017-12-14 12:48:55 +00:00
COPYING.NEWLIB
depcomp
djunpack.bat
install-sh
libtool.m4
lt~obsolete.m4
ltgcc.m4
ltmain.sh
ltoptions.m4
ltsugar.m4
ltversion.m4
MAINTAINERS
Makefile.def
Makefile.in
Makefile.tpl
makefile.vms
missing
mkdep
mkinstalldirs
move-if-change
README
README-maintainer-mode
setup.com
src-release.sh Add -l option to src-release script. 2017-09-15 16:18:20 +01:00
symlink-tree
ylwrap

		   README for GNU development tools

This directory contains various GNU compilers, assemblers, linkers, 
debuggers, etc., plus their support routines, definitions, and documentation.

If you are receiving this as part of a GDB release, see the file gdb/README.
If with a binutils release, see binutils/README;  if with a libg++ release,
see libg++/README, etc.  That'll give you info about this
package -- supported targets, how to use it, how to report bugs, etc.

It is now possible to automatically configure and build a variety of
tools with one command.  To build all of the tools contained herein,
run the ``configure'' script here, e.g.:

	./configure 
	make

To install them (by default in /usr/local/bin, /usr/local/lib, etc),
then do:
	make install

(If the configure script can't determine your type of computer, give it
the name as an argument, for instance ``./configure sun4''.  You can
use the script ``config.sub'' to test whether a name is recognized; if
it is, config.sub translates it to a triplet specifying CPU, vendor,
and OS.)

If you have more than one compiler on your system, it is often best to
explicitly set CC in the environment before running configure, and to
also set CC when running make.  For example (assuming sh/bash/ksh):

	CC=gcc ./configure
	make

A similar example using csh:

	setenv CC gcc
	./configure
	make

Much of the code and documentation enclosed is copyright by
the Free Software Foundation, Inc.  See the file COPYING or
COPYING.LIB in the various directories, for a description of the
GNU General Public License terms under which you can copy the files.

REPORTING BUGS: Again, see gdb/README, binutils/README, etc., for info
on where and how to report problems.