If a baseboard file wants to override a proc foo, but also use the original
proc, it'll have to do something like:
...
rename foo save_foo
proc foo { } {
...
set res [save_foo]
...
return res
}
...
This adds a new proc named save_foo, which introduces the risk of clashing with
an existing proc.
There's a pattern in the gdb testsuite procs, that facilitates this override:
...
proc default_foo { } {
...
}
proc foo { } {
return [default_foo]
}
...
such that in a baseboard file we don't need the rename:
...
proc foo { } {
...
set res [default_foo]
...
return res
}
...
The exception to the pattern though is gdb_init, which has a default_gdb_init
counterpart, but contains much more code than just the call to
default_gdb_init.
Fix this by moving all but the call to default_gdb_init to default_gdb_init.
Tested on x86_64-linux.
gdb/testsuite/ChangeLog:
2020-06-18 Tom de Vries <tdevries@suse.de>
* lib/gdb.exp (gdb_init): Move all but call to default_gdb_init to ...
(default_gdb_init): ... here.
|
||
|---|---|---|
| .. | ||
| ada.exp | ||
| append_gdb_boards_dir.exp | ||
| build-piece.exp | ||
| cache.exp | ||
| check-test-names.exp | ||
| cl_util.c | ||
| cl_util.h | ||
| compile-support.exp | ||
| compiler.c | ||
| compiler.cc | ||
| completion-support.exp | ||
| cp-support.exp | ||
| d-support.exp | ||
| data-structures.exp | ||
| dtrace.exp | ||
| dwarf.exp | ||
| fortran.exp | ||
| future.exp | ||
| gdb-guile.exp | ||
| gdb-python.exp | ||
| gdb-utils.exp | ||
| gdb.exp | ||
| gdbserver-support.exp | ||
| gen-perf-test.exp | ||
| gnat_debug_info_test.adb | ||
| go.exp | ||
| jit-elf-helpers.exp | ||
| memory.exp | ||
| mi-support.exp | ||
| objc.exp | ||
| opencl_hostapp.c | ||
| opencl_kernel.cl | ||
| opencl.exp | ||
| pascal.exp | ||
| pdtrace.in | ||
| perftest.exp | ||
| prelink-support.exp | ||
| prompt.exp | ||
| range-stepping-support.exp | ||
| read1.c | ||
| rust-support.exp | ||
| selftest-support.exp | ||
| set_unbuffered_mode.c | ||
| sym-info-cmds.exp | ||
| trace-support.exp | ||
| tuiterm.exp | ||
| unbuffer_output.c | ||
| valgrind.exp | ||