Go to file
Luis Machado 1bd57575dc Fix gdb.base/corefile2.exp regression when running Docker/AUFS
The following failures started showing up after commit
bb2a67773c - "Use a std::vector in target_section_table":

FAIL: gdb.base/corefile2.exp: renamed binfile: print/x mbuf_ro[0]@4
FAIL: gdb.base/corefile2.exp: renamed binfile: print/x mbuf_ro[pagesize-4]@4
FAIL: gdb.base/corefile2.exp: renamed binfile: print/x mbuf_ro[-3]@6
FAIL: gdb.base/corefile2.exp: renamed binfile: print/x mbuf_rw[pagesize-3]@6
FAIL: gdb.base/corefile2.exp: renamed binfile: print/x mbuf_ro[pagesize-3]@6

I tracked it down to a problem in core_target::xfer_partial, at this point:

	if (!m_core_file_mappings.empty ())
	  xfer_status = xfer_memory_via_mappings (readbuf, writebuf, offset,
						  len, xfered_len);
	else
	  xfer_status = this->beneath ()->xfer_partial (object, annex, readbuf,
							writebuf, offset, len,
							xfered_len);

It seems commit bb2a67773c uncovered a latent bug when handling a particular
case where things are running within a Docker container using the AUFS storage
driver.

When building the file mappings for a core file, we call
gdbarch_read_core_file_mappings, which in turn passes a couple lambda
callbacks. One pre-loop and one in-loop.

The catch is that commit bb2a67773c reworked the pre-loop lambda and
made it do nothing. Before that commit, we always allocated
m_core_file_mappings in that lambda.

Now, when calling the in-loop lambda, we don't touch m_core_file_mappings
because the bfd is nullptr (given Docker leaks the host system path, and that
file doesn't exist within the container itself).

So, instead, we add an entry to the m_core_unavailable_mappings vector.

When we reach core_target::xfer_partial, we're only checking for an empty
m_core_file_mappings. Given it is now empty, we take the path of reading
the contents from the file, not the core file. This reads back unexpected
results.

The following patch fixes this by also checking for
m_core_unavailable_mappings, given core_target::xfer_memory_via_mappings
already handles the Docker/AUFS situation.

gdb/ChangeLog:

2020-10-22  Luis Machado  <luis.machado@linaro.org>

	* corelow.c (core_target::xfer_partial): Also check for an empty
	m_core_unavailable_mappings vector.
2020-10-22 10:59:25 -03:00
bfd Fix printf formatting errors where "0x" is used as a prefix for a decimal number. 2020-10-22 12:00:10 +01:00
binutils binutils: Report error message on error 2020-10-22 04:48:29 -07:00
config sync libiberty from gcc 2020-09-08 20:12:57 +09:30
contrib Import mklog.py from gcc repo 2020-09-25 10:24:44 -04:00
cpu Fix spelling mistakes 2020-10-05 14:20:15 +01:00
elfcpp gold: Update GNU_PROPERTY_X86_XXX macros 2020-10-13 05:21:05 -07:00
etc texi2pod.pl: import support for @t{...} from gcc 2020-01-15 12:58:09 -05:00
gas arm: Fix the wrong error message string for mve vldr/vstr (PR26763). 2020-10-22 13:30:35 +01:00
gdb Fix gdb.base/corefile2.exp regression when running Docker/AUFS 2020-10-22 10:59:25 -03:00
gdbserver gdbserver: fix overlap in sprintf argument and buffer 2020-10-21 10:42:26 -04:00
gdbsupport gdb: Have allocate_target_description return a unique_ptr 2020-10-08 10:14:14 +01:00
gnulib gnulib: Ensure all libraries are used when building gdb/gdbserver 2020-10-09 09:31:43 +01:00
gold gold: Skip some incremental tests 2020-10-13 05:23:13 -07:00
gprof Unify Solaris procfs and largefile handling 2020-07-30 15:41:50 +02:00
include Remove libctf/mkerrors.sed 2020-10-21 11:52:17 -06:00
intl Regen with blessed automake-1.15.1 2020-02-20 13:02:24 +10:30
ld ld: Pass -fno-lto to non LTO tests 2020-10-22 06:04:36 -07:00
libctf Remove libctf/mkerrors.sed 2020-10-21 11:52:17 -06:00
libdecnumber Run autoreconf -vf throughout 2020-07-29 16:03:55 -04:00
libiberty Sync libiberty and include with GCC for get_DW_UT_name. 2020-09-24 22:55:24 +02:00
opcodes opcodes/po/es.po: Remove the duplicated entry 2020-10-22 05:21:35 -07:00
readline Update readline/README to mention patchlevel 2020-06-30 15:17:07 -06:00
sim sim: move ChangeLog entries into the correct files 2020-10-22 13:39:26 +01:00
texinfo
zlib Merge changes from GCC for the config/ directory 2020-02-19 17:51:24 +00:00
.cvsignore
.gitattributes
.gitignore Add profiling outputs to .gitignore 2019-12-26 06:54:58 +01:00
ar-lib
ChangeLog gdb/gdbserver: add dependencies for distclean-gnulib 2020-10-14 15:05:14 +01:00
compile
config-ml.in
config.guess Update top level config files with copies from the official repository. 2020-01-18 13:43:19 +00:00
config.rpath
config.sub Update top level config files with copies from the official repository. 2020-01-18 13:43:19 +00:00
configure config/debuginfod.m4: Use PKG_CHECK_MODULES 2020-07-24 15:16:20 -04:00
configure.ac config/debuginfod.m4: Use PKG_CHECK_MODULES 2020-07-24 15:16:20 -04:00
COPYING
COPYING3
COPYING3.LIB
COPYING.LIB
COPYING.LIBGLOSS
COPYING.NEWLIB
depcomp
djunpack.bat
install-sh
libtool.m4
lt~obsolete.m4
ltgcc.m4
ltmain.sh
ltoptions.m4
ltsugar.m4
ltversion.m4
MAINTAINERS Move gdbserver to top level 2020-02-07 08:42:25 -07:00
Makefile.def gdb/gdbserver: add dependencies for distclean-gnulib 2020-10-14 15:05:14 +01:00
Makefile.in gdb/gdbserver: add dependencies for distclean-gnulib 2020-10-14 15:05:14 +01:00
Makefile.tpl Revert "Sync top level files with versions from gcc." 2019-05-30 11:17:19 +01:00
makefile.vms
missing
mkdep
mkinstalldirs
move-if-change
multilib.am
README
README-maintainer-mode
setup.com
src-release.sh Move gdbserver to top level 2020-02-07 08:42:25 -07:00
symlink-tree
test-driver
ylwrap

		   README for GNU development tools

This directory contains various GNU compilers, assemblers, linkers, 
debuggers, etc., plus their support routines, definitions, and documentation.

If you are receiving this as part of a GDB release, see the file gdb/README.
If with a binutils release, see binutils/README;  if with a libg++ release,
see libg++/README, etc.  That'll give you info about this
package -- supported targets, how to use it, how to report bugs, etc.

It is now possible to automatically configure and build a variety of
tools with one command.  To build all of the tools contained herein,
run the ``configure'' script here, e.g.:

	./configure 
	make

To install them (by default in /usr/local/bin, /usr/local/lib, etc),
then do:
	make install

(If the configure script can't determine your type of computer, give it
the name as an argument, for instance ``./configure sun4''.  You can
use the script ``config.sub'' to test whether a name is recognized; if
it is, config.sub translates it to a triplet specifying CPU, vendor,
and OS.)

If you have more than one compiler on your system, it is often best to
explicitly set CC in the environment before running configure, and to
also set CC when running make.  For example (assuming sh/bash/ksh):

	CC=gcc ./configure
	make

A similar example using csh:

	setenv CC gcc
	./configure
	make

Much of the code and documentation enclosed is copyright by
the Free Software Foundation, Inc.  See the file COPYING or
COPYING.LIB in the various directories, for a description of the
GNU General Public License terms under which you can copy the files.

REPORTING BUGS: Again, see gdb/README, binutils/README, etc., for info
on where and how to report problems.