MatCat.OpenSource/8sa1-binutils-gdb
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Remove old lint code

Browse Source 
This removes dead code that, according to the comments, existed to
placate lint.  I don't think this has been relevant in a long time,
and certainly not since gdb switched to C++.

Tested by rebuilding.

ChangeLog
2018-07-30  Tom Tromey  <tom@tromey.com>

	* cli/cli-decode.c (lookup_cmd): Remove lint code.
	* value.c (unpack_long): Remove lint code.
	* valops.c (value_ind): Remove lint code.
	* valarith.c (value_x_binop, value_x_unop, value_equal)
	(value_pos): Remove lint code.
This commit is contained in:
Tom Tromey 2018-07-29 15:23:51 -06:00
parent a05b9f5e1e
commit dba7455e76
5 changed files with 11 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
gdb/ChangeLog
View File

@ -1,3 +1,11 @@
2018-07-30 Tom Tromey <tom@tromey.com>
* cli/cli-decode.c (lookup_cmd): Remove lint code.
* value.c (unpack_long): Remove lint code.
* valops.c (value_ind): Remove lint code.
* valarith.c (value_x_binop, value_x_unop, value_equal)
(value_pos): Remove lint code.
2018-07-28 Tom de Vries <tdevries@suse.de>
* eval.c (evaluate_subexp_for_sizeof): Interpret size of dynamic type

1
gdb/cli/cli-decode.c
View File

@ -1561,7 +1561,6 @@ lookup_cmd (const char **line, struct cmd_list_element *list,
}
error (_("Ambiguous %scommand \"%s\": %s."), local_cmdtype,
*line, ambbuf);
return 0; /* lint */
}
}
else

20
gdb/valarith.c
View File

@ -504,9 +504,6 @@ value_x_binop (struct value *arg1, struct value *arg2, enum exp_opcode op,
}
throw_error (NOT_FOUND_ERROR,
_("member function %s not found"), tstr);
#ifdef lint
return call_function_by_hand (argvec[0], 2 - static_memfuncp, argvec + 1);
#endif
}
/* We know that arg1 is a structure, so try to find a unary user
@ -622,8 +619,6 @@ value_x_unop (struct value *arg1, enum exp_opcode op, enum noside noside)
}
throw_error (NOT_FOUND_ERROR,
_("member function %s not found"), tstr);
return 0; /* For lint -- never reached */
}
@ -1533,10 +1528,7 @@ value_equal (struct value *arg1, struct value *arg2)
return value_strcmp (arg1, arg2) == 0;
}
else
{
error (_("Invalid type combination in equality test."));
return 0; /* For lint -- never reached. */
}
error (_("Invalid type combination in equality test."));
}
/* Compare values based on their raw contents. Useful for arrays since
@ -1628,10 +1620,7 @@ value_pos (struct value *arg1)
|| (TYPE_CODE (type) == TYPE_CODE_ARRAY && TYPE_VECTOR (type)))
return value_from_contents (type, value_contents (arg1));
else
{
error (_("Argument to positive operation not a number."));
return 0; /* For lint -- never reached. */
}
error (_("Argument to positive operation not a number."));
}
struct value *
@ -1663,10 +1652,7 @@ value_neg (struct value *arg1)
return val;
}
else
{
error (_("Argument to negate operation not a number."));
return 0; /* For lint -- never reached. */
}
error (_("Argument to negate operation not a number."));
}
struct value *

1
gdb/valops.c
View File

@ -1588,7 +1588,6 @@ value_ind (struct value *arg1)
}
error (_("Attempt to take contents of a non-pointer value."));
return 0; /* For lint -- never reached. */
}
/* Create a value for an array by allocating space in GDB, copying the

1
gdb/value.c
View File

@ -2777,7 +2777,6 @@ unpack_long (struct type *type, const gdb_byte *valaddr)
default:
error (_("Value can't be converted to integer."));
}
return 0; /* Placate lint. */
}
/* Unpack raw data (copied from debugee, target byte order) at VALADDR