Make regcache_cpy_no_passthrough static

regcache_cpy_no_passthrough is no longer used for a standalone call.

gdb/ChangeLog
2015-05-13  Jan Kratochvil  <jan.kratochvil@redhat.com>

	* regcache.c (regcache_cpy_no_passthrough): New declaration.
	(regcache_cpy_no_passthrough): Make it static, add function comment.
	* regcache.h (regcache_dup, regcache_cpy): Reduce/update their comment.
	(regcache_cpy_no_passthrough): Remove declaration.
This commit is contained in:
Jan Kratochvil 2015-05-13 20:47:33 +02:00
parent 46c03469b3
commit bd49952bd7
3 changed files with 18 additions and 8 deletions

View File

@ -1,3 +1,10 @@
2015-05-13 Jan Kratochvil <jan.kratochvil@redhat.com>
* regcache.c (regcache_cpy_no_passthrough): New declaration.
(regcache_cpy_no_passthrough): Make it static, add function comment.
* regcache.h (regcache_dup, regcache_cpy): Reduce/update their comment.
(regcache_cpy_no_passthrough): Remove declaration.
2015-05-13 Jan Kratochvil <jan.kratochvil@redhat.com>
* gdbthread.h (struct thread_control_state): Update comment for

View File

@ -391,6 +391,9 @@ do_cooked_read (void *src, int regnum, gdb_byte *buf)
return regcache_cooked_read (regcache, regnum, buf);
}
static void regcache_cpy_no_passthrough (struct regcache *dst,
struct regcache *src);
void
regcache_cpy (struct regcache *dst, struct regcache *src)
{
@ -407,7 +410,12 @@ regcache_cpy (struct regcache *dst, struct regcache *src)
regcache_cpy_no_passthrough (dst, src);
}
void
/* Copy/duplicate the contents of a register cache. Unlike regcache_cpy,
which is pass-through, this does not go through to the target.
Only values values already in the cache are transferred. The SRC and DST
buffers must not overlap. */
static void
regcache_cpy_no_passthrough (struct regcache *dst, struct regcache *src)
{
gdb_assert (src != NULL && dst != NULL);

View File

@ -224,17 +224,12 @@ extern void regcache_save (struct regcache *dst,
/* Copy/duplicate the contents of a register cache. By default, the
operation is pass-through. Writes to DST and reads from SRC will
go through to the target.
go through to the target. See also regcache_cpy_no_passthrough.
The ``cpy'' functions can not have overlapping SRC and DST buffers.
``no passthrough'' versions do not go through to the target. They
only transfer values already in the cache. */
regcache_cpy can not have overlapping SRC and DST buffers. */
extern struct regcache *regcache_dup (struct regcache *regcache);
extern void regcache_cpy (struct regcache *dest, struct regcache *src);
extern void regcache_cpy_no_passthrough (struct regcache *dest,
struct regcache *src);
extern void registers_changed (void);
extern void registers_changed_ptid (ptid_t);