* listing.c (listing_listing): Remove useless loop.

* macro.c (macro_expand): Remove is_positional local variable.
	* read.c (s_comm_internal): Simplify `if' condition 1 || x -> 1
	and simplify surrounding expressions, where possible.
	(assign_symbol): Likewise.
	(s_weakref): Likewise.
	* symbols.c (colon): Likewise.
This commit is contained in:
Ben Elliston 2006-05-01 09:21:46 +00:00
parent c35da14031
commit 89cdfe5739
5 changed files with 16 additions and 30 deletions

View File

@ -1,3 +1,13 @@
2006-05-01 Ben Elliston <bje@au.ibm.com>
* listing.c (listing_listing): Remove useless loop.
* macro.c (macro_expand): Remove is_positional local variable.
* read.c (s_comm_internal): Simplify `if' condition 1 || x -> 1
and simplify surrounding expressions, where possible.
(assign_symbol): Likewise.
(s_weakref): Likewise.
* symbols.c (colon): Likewise.
2006-05-01 James Lemke <jwlemke@wasabisystems.com>
* subsegs.c (subseg_set_rest): Always set seginfp->frchainP if NULL.

View File

@ -946,15 +946,6 @@ listing_listing (char *name ATTRIBUTE_UNUSED)
buffer = xmalloc (listing_rhs_width);
data_buffer = xmalloc (MAX_BYTES);
eject = 1;
list = head;
while (list != (list_info_type *) NULL && 0)
{
if (list->next)
list->frag = list->next->frag;
list = list->next;
}
list = head->next;
while (list)

View File

@ -1025,7 +1025,6 @@ macro_expand (int idx, sb *in, macro_entry *m, sb *out)
sb t;
formal_entry *ptr;
formal_entry *f;
int is_positional = 0;
int is_keyword = 0;
int narg = 0;
const char *err = NULL;
@ -1116,8 +1115,6 @@ macro_expand (int idx, sb *in, macro_entry *m, sb *out)
}
else
{
/* This is a positional arg. */
is_positional = 1;
if (is_keyword)
{
err = _("can't mix positional and keyword arguments");

View File

@ -1,6 +1,6 @@
/* read.c - read a source file -
Copyright 1986, 1987, 1990, 1991, 1992, 1993, 1994, 1995, 1996, 1997,
1998, 1999, 2000, 2001, 2002, 2003, 2004, 2005
1998, 1999, 2000, 2001, 2002, 2003, 2004, 2005, 2006
Free Software Foundation, Inc.
This file is part of GAS, the GNU Assembler.
@ -1478,10 +1478,7 @@ s_comm_internal (int param,
ignore_rest_of_line ();
goto out;
}
/* This could be avoided when the symbol wasn't used so far, but
the comment in struc-symbol.h says this flag isn't reliable. */
if (1 || !symbol_used_p (symbolP))
symbolP = symbol_clone (symbolP, 1);
symbolP = symbol_clone (symbolP, 1);
S_SET_SEGMENT (symbolP, undefined_section);
S_SET_VALUE (symbolP, 0);
symbol_set_frag (symbolP, &zero_address_frag);
@ -2812,10 +2809,7 @@ assign_symbol (char *name, int mode)
/* If the symbol is volatile, copy the symbol and replace the
original with the copy, so that previous uses of the symbol will
retain the value of the symbol at the point of use. */
else if (S_IS_VOLATILE (symbolP)
/* This could be avoided when the symbol wasn't used so far, but
the comment in struc-symbol.h says this flag isn't reliable. */
&& (1 || symbol_used_p (symbolP)))
else if (S_IS_VOLATILE (symbolP))
symbolP = symbol_clone (symbolP, 1);
}
@ -3186,17 +3180,14 @@ s_weakref (int ignore ATTRIBUTE_UNUSED)
if (S_IS_DEFINED (symbolP) || symbol_equated_p (symbolP))
{
if(!S_IS_VOLATILE (symbolP))
if (!S_IS_VOLATILE (symbolP))
{
as_bad (_("symbol `%s' is already defined"), name);
*end_name = delim;
ignore_rest_of_line ();
return;
}
/* This could be avoided when the symbol wasn't used so far, but
the comment in struc-symbol.h says this flag isn't reliable. */
if (1 || !symbol_used_p (symbolP))
symbolP = symbol_clone (symbolP, 1);
symbolP = symbol_clone (symbolP, 1);
S_CLEAR_VOLATILE (symbolP);
}

View File

@ -336,10 +336,7 @@ colon (/* Just seen "x:" - rattle symbols & frags. */
|| S_IS_COMMON (symbolP)
|| S_IS_VOLATILE (symbolP))
{
if (S_IS_VOLATILE (symbolP)
/* This could be avoided when the symbol wasn't used so far, but
the comment in struc-symbol.h says this flag isn't reliable. */
&& (1 || !symbol_used_p (symbolP)))
if (S_IS_VOLATILE (symbolP))
{
symbolP = symbol_clone (symbolP, 1);
S_SET_VALUE (symbolP, 0);