MatCat.OpenSource/8sa1-binutils-gdb
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Fix incorrect casts.

Browse Source 
gold/
	PR gold/19577
	* reloc.h (Bits::has_unsigned_overflow32): Fix static_cast.
	(Bits::has_unsigned_overflow): Remove unnecessary static_cast.
This commit is contained in:
Cary Coutant 2016-02-06 10:28:36 -08:00
parent 3b8bcce879
commit 72c55146bb
2 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
gold/ChangeLog
View File

@ -1,3 +1,9 @@
2016-02-06 Cary Coutant <ccoutant@gmail.com>
PR gold/19577
* reloc.h (Bits::has_unsigned_overflow32): Fix static_cast.
(Bits::has_unsigned_overflow): Remove unnecessary static_cast.
2016-02-06 Cary Coutant <ccoutant@gmail.com>
PR gold/19577

4
gold/reloc.h
View File

@ -1015,7 +1015,7 @@ class Bits
gold_assert(bits > 0 && bits <= 32);
if (bits == 32)
return false;
uint32_t max = static_cast<int32_t>((1U << bits) - 1);
uint32_t max = static_cast<uint32_t>((1U << bits) - 1);
return val > max;
}
@ -1081,7 +1081,7 @@ class Bits
gold_assert(bits > 0 && bits <= 64);
if (bits == 64)
return false;
uint64_t max = static_cast<int64_t>((static_cast<uint64_t>(1) << bits) - 1);
uint64_t max = (static_cast<uint64_t>(1) << bits) - 1;
return val > max;
}