diff --git a/gdb/ChangeLog b/gdb/ChangeLog index f61cfda48d..90bfac7747 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,7 @@ +2020-12-11 Tom Tromey + + * varobj.c (instantiate_pretty_printer): Use gdbpy_ref. + 2020-12-11 Tom Tromey * varobj.c (varobj_clear_saved_item): Remove. diff --git a/gdb/varobj.c b/gdb/varobj.c index 941c38c1ce..ba0e1357d3 100644 --- a/gdb/varobj.c +++ b/gdb/varobj.c @@ -459,16 +459,11 @@ varobj_delete (struct varobj *var, bool only_children) static PyObject * instantiate_pretty_printer (PyObject *constructor, struct value *value) { - PyObject *val_obj = NULL; - PyObject *printer; - - val_obj = value_to_value_object (value); - if (! val_obj) + gdbpy_ref<> val_obj (value_to_value_object (value)); + if (val_obj == nullptr) return NULL; - printer = PyObject_CallFunctionObjArgs (constructor, val_obj, NULL); - Py_DECREF (val_obj); - return printer; + return PyObject_CallFunctionObjArgs (constructor, val_obj.get (), NULL); } #endif