diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog index 69abe761df..f5fe029c04 100644 --- a/gdb/testsuite/ChangeLog +++ b/gdb/testsuite/ChangeLog @@ -1,3 +1,9 @@ +2021-04-06 Tom de Vries + + PR testsuite/27691 + * gdb.threads/gcore-thread.exp: Don't call gdb_core_cmd with core + file "". + 2021-04-01 Egeyar Bagcioglu * lib/pdtrace.in: Fix obvious typo. diff --git a/gdb/testsuite/gdb.threads/gcore-thread.exp b/gdb/testsuite/gdb.threads/gcore-thread.exp index 2a6ab17284..35c75f7a49 100644 --- a/gdb/testsuite/gdb.threads/gcore-thread.exp +++ b/gdb/testsuite/gdb.threads/gcore-thread.exp @@ -114,11 +114,13 @@ if {"$core0file" != ""} { # Now restart gdb and load the corefile. clean_restart ${testfile} -foreach name { corefile core0file } { with_test_prefix $name { - set core_loaded [gdb_core_cmd [subst $$name] "re-load generated corefile"] +proc load_core { filename } { + global horiz nl + + set core_loaded [gdb_core_cmd $filename "re-load generated corefile"] if { $core_loaded == -1 } { # No use proceeding from here. - continue + return } # FIXME: now what can we test about the thread state? @@ -139,4 +141,14 @@ foreach name { corefile core0file } { with_test_prefix $name { gdb_test "info threads" "\\* ${horiz} thread2 .*${nl}" \ "thread2 is current thread in corefile" -}} +} + +foreach name { corefile core0file } { + set filename [subst $$name] + if { $filename == "" } { + continue + } + with_test_prefix $name { + load_core $filename + } +}